Skip to content

Fix wrong imu offset #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix wrong imu offset #25

wants to merge 1 commit into from

Conversation

TomasLeTrain
Copy link

hardware/src/hardware/IMU/V5InertialSensor.cpp

Line 45 in 48e2567

m_offset = rotation - raw;

This expands to
m_offset = rotation - (from_cDeg(result * m_gyroScalar) + m_offset);
which means the old offset affects the new one. This results in getRotation() returning rotation - offset rather than rotation after the second time setRotation() has been called.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@TomasLeTrain